Skip to content

[DataGrid] Add key prop to GridFilterInputMultipleValue#14302

Merged
MBilalShafi merged 3 commits intomui:masterfrom
sai6855:add-key
Aug 29, 2024
Merged

[DataGrid] Add key prop to GridFilterInputMultipleValue#14302
MBilalShafi merged 3 commits intomui:masterfrom
sai6855:add-key

Conversation

@sai6855
Copy link
Copy Markdown
Member

@sai6855 sai6855 commented Aug 23, 2024 •
edited by MBilalShafi
Loading

Closes #14299

@sai6855 sai6855 marked this pull request as draft August 23, 2024 10:03
@sai6855 sai6855 changed the title [DataGrid] Add key [DataGrid] Add key prop to GridFilter Aug 23, 2024
@sai6855 sai6855 added the scope: data grid Changes related to the data grid. label Aug 23, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Aug 23, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14302--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 54252b9

@sai6855 sai6855 changed the title [DataGrid] Add key prop to GridFilter [DataGrid] Add key prop to GridFilterInputMultipleValue.tsx Aug 23, 2024
sai6855
sai6855 commented Aug 23, 2024
View reviewed changes
Comment thread packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleValue.tsx
Comment on lines +68 to +79
value.map((option, index) => {
const { key, ...tagProps } = getTagProps({ index });
return (
<rootProps.slots.baseChip
key={key}
variant="outlined"
size="small"
label={option}
{...tagProps}
/>
);
})
Copy link
Copy Markdown
Member Author

@sai6855 sai6855 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is taken from

mui-x/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx

Lines 110 to 120 in 45b2835

renderTags={(value, getTagProps) =>
value.map((option, index) => {
const { key, ...tagProps } = getTagProps({ index });
return (
<rootProps.slots.baseChip
key={key}
variant="outlined"
size="small"
label={getOptionLabel(option)}
{...tagProps}
/>

@sai6855 sai6855 marked this pull request as ready for review August 23, 2024 10:23
@sai6855 sai6855 changed the title [DataGrid] Add key prop to GridFilterInputMultipleValue.tsx [DataGrid] Add key prop to GridFilterInputMultipleValue Aug 23, 2024
@sai6855 sai6855 mentioned this pull request Aug 23, 2024
Closed
@michelengelen michelengelen added the type: bug It doesn't behave as expected. label Aug 23, 2024
@MBilalShafi MBilalShafi changed the title [DataGrid] Add key prop to GridFilterInputMultipleValue [DataGrid] Add key prop to GridFilterInputMultipleValue Aug 29, 2024
MBilalShafi
MBilalShafi approved these changes Aug 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MBilalShafi MBilalShafi merged commit 60b494d into mui:master Aug 29, 2024
This was referenced Sep 27, 2024
Open
Open
Open
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 5, 2024
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Oct 6, 2024
Closed
This was referenced Oct 25, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

@kenanyusuf kenanyusuf Awaiting requested review from kenanyusuf

Assignees

No one assigned

Labels

scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Warning: A props object containing a "key" prop is being spread into JSX

4 participants

@sai6855 @mui-bot @MBilalShafi @michelengelen