Skip to content

[DateRangePicker] Add accessible name to calendar grid#13538

Merged
LukasTy merged 5 commits intomui:masterfrom
LukasTy:fix-date-range-calendar-grid-label
Jun 19, 2024
Merged

[DateRangePicker] Add accessible name to calendar grid#13538
LukasTy merged 5 commits intomui:masterfrom
LukasTy:fix-date-range-calendar-grid-label

Conversation

@LukasTy
Copy link
Copy Markdown
Member

@LukasTy LukasTy commented Jun 19, 2024

Fixes #13534

  • Add id and aria-labelledby relationship to DateRangeCalendar same as we have for DateCalendar.
  • Update tests to benefit from this relationship instead of accessing parent elements and relying on consistent DOM.

@LukasTy LukasTy added type: bug It doesn't behave as expected. accessibility a11y scope: pickers Changes related to the date/time pickers. component: DateRangePicker labels Jun 19, 2024
@LukasTy LukasTy self-assigned this Jun 19, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Jun 19, 2024

Deploy preview: https://deploy-preview-13538--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9d24724

@LukasTy LukasTy requested a review from a team June 19, 2024 08:09
LukasTy added 2 commits June 19, 2024 11:51
Better support for custom calendar header components
@LukasTy LukasTy requested a review from flaviendelangle June 19, 2024 08:56
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️
Thanks for taking care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility a11y scope: pickers Changes related to the date/time pickers. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pickers] DateRangeCalendar grid is missing it's accessible name

3 participants