Skip to content

[charts] Divide CartesianProvider to use logic in Pro package#13531

Merged
JCQuintas merged 16 commits intomui:masterfrom
JCQuintas:divide-cartesian-context-provider
Jun 19, 2024
Merged

[charts] Divide CartesianProvider to use logic in Pro package#13531
JCQuintas merged 16 commits intomui:masterfrom
JCQuintas:divide-cartesian-context-provider

Conversation

@JCQuintas
Copy link
Copy Markdown
Member

@JCQuintas JCQuintas commented Jun 18, 2024 •
edited
Loading

  • This shouldn't change any of the current behaviours
  • Preparing the package for PRO

related #13405

@mui-bot
Copy link
Copy Markdown

mui-bot commented Jun 18, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13531--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a45bbc3

@JCQuintas
Copy link
Copy Markdown
Member Author

JCQuintas commented Jun 18, 2024

Will create conflicts with #13471

@JCQuintas JCQuintas requested a review from alexfauquette June 18, 2024 14:31
@JCQuintas JCQuintas self-assigned this Jun 18, 2024
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Jun 18, 2024
alexfauquette
alexfauquette reviewed Jun 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refacto. Just one question to push it a bit further. But I'm not sure it's feasible

Comment thread packages/x-charts/src/context/CartesianProvider/CartesianContext.ts Outdated
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts Outdated
JCQuintas and others added 4 commits June 18, 2024 17:50
@JCQuintas @alexfauquette
Update packages/x-charts/src/context/CartesianProvider/CartesianConte…
2c750e2 
…xt.ts

Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas
Dont error as MUI Y
ca5319a
@JCQuintas
Simplify computeValue for X
f0040c9
@JCQuintas
computeValue for Y
6971548
alexfauquette
alexfauquette reviewed Jun 19, 2024
View reviewed changes
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts
alexfauquette
alexfauquette reviewed Jun 19, 2024
View reviewed changes
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts Outdated
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts Outdated
Comment thread packages/x-charts/src/context/CartesianProvider/computeValue.ts Outdated
JCQuintas and others added 3 commits June 19, 2024 10:29
@JCQuintas @alexfauquette
Update packages/x-charts/src/context/CartesianProvider/computeValue.ts
5062469 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @alexfauquette
Update packages/x-charts/src/context/CartesianProvider/computeValue.ts
b606028 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas
Move consts back out
a45bbc3
@JCQuintas JCQuintas requested a review from alexfauquette June 19, 2024 08:50
alexfauquette
alexfauquette approved these changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@JCQuintas JCQuintas merged commit 428a78f into mui:master Jun 19, 2024
@JCQuintas JCQuintas deleted the divide-cartesian-context-provider branch June 19, 2024 11:34
@DMPatod DMPatod mentioned this pull request Jul 13, 2024
Open
@DMPatod DMPatod mentioned this pull request Jul 13, 2024
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@JCQuintas @alexfauquette @DungTiger
[charts] Divide CartesianProvider to use logic in Pro package (mui#…
ef475af 
…13531)

Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@JCQuintas @alexfauquette @thomasmoon
[charts] Divide CartesianProvider to use logic in Pro package (mui#…
0fd299b 
…13531)

Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JCQuintas @mui-bot @alexfauquette