[infra] Remove explicit @testing-library/react dependency#13478
Merged
LukasTy merged 1 commit intomui:masterfrom Jun 14, 2024
Merged
[infra] Remove explicit @testing-library/react dependency#13478LukasTy merged 1 commit intomui:masterfrom
@testing-library/react dependency#13478LukasTy merged 1 commit intomui:masterfrom
Conversation
|
Deploy preview: https://deploy-preview-13478--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
Jun 14, 2024
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #13463 (comment)
We are not using this dependency directly and it is even disallowed:
mui-x/.eslintrc.js
Line 187 in 40b6038
This dependency is now coming from: https://github.com/mui/material-ui/blob/58831f0a1861337a7dddffe522cf3edbbeaf00d9/packages-internal/test-utils/package.json#L42
This will remove the need to separately control the dependency version and possibly introduce a discrepancy between expected package versions: #13429