[TreeView] Fix typing of the Multiple generic#10478
Merged
flaviendelangle merged 2 commits intomui:masterfrom Sep 26, 2023
Merged
[TreeView] Fix typing of the Multiple generic#10478flaviendelangle merged 2 commits intomui:masterfrom
flaviendelangle merged 2 commits intomui:masterfrom
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10478--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
flaviendelangle
commented
Sep 26, 2023
| it('should warn when switching from controlled to uncontrolled of the selected prop', () => { | ||
| const { setProps } = render( | ||
| <TreeView selected={[]}> | ||
| <TreeView selected={null}> |
Member
Author
There was a problem hiding this comment.
This test was not coherent
Janpot
approved these changes
Sep 26, 2023
Member
Janpot
left a comment
There was a problem hiding this comment.
Tested and confirmed with https://pkg.csb.dev/mui/mui-x/commit/e0613234/@mui/x-tree-view
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mui/toolpad#2716 (comment)
Fixes #10473