Skip to content

[DataGrid] Fix column headers scroll when theme scoping is used#10437

Merged
cherniavskii merged 1 commit intomui:masterfrom
cherniavskii:fix-header-scrolling-with-joy
Sep 25, 2023
Merged

[DataGrid] Fix column headers scroll when theme scoping is used#10437
cherniavskii merged 1 commit intomui:masterfrom
cherniavskii:fix-header-scrolling-with-joy

Conversation

@cherniavskii
Copy link
Copy Markdown
Member

Fixes #10430

@cherniavskii cherniavskii added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. labels Sep 23, 2023
@mui-bot
Copy link
Copy Markdown

mui-bot commented Sep 23, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10437--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -220.7 -8.9 -69.5 -117.84 84.586
Sort 100k rows ms 606 1,322.6 1,193 1,043.32 242.382
Select 100k rows ms 603.4 713.6 647.4 655.36 47.321
Deselect 100k rows ms 140.3 223.5 173.2 178.94 26.767

Generated by 🚫 dangerJS against d4c07ee

@cherniavskii
Copy link
Copy Markdown
Member Author

I think the general issue is that the useTheme from @mui/system doesn't play well with theme scoping used for the Material UI theme.
@siriwatknp Can you take a look at it? Is there something we can improve here to make useTheme from @mui/system "just work"?

@cherniavskii cherniavskii marked this pull request as ready for review September 24, 2023 14:39
@cherniavskii cherniavskii merged commit a982158 into mui:master Sep 25, 2023
MBilalShafi added a commit to yaredtsy/mui-x that referenced this pull request Oct 11, 2023
@cherniavskii cherniavskii deleted the fix-header-scrolling-with-joy branch October 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DataGridPro V6] Joy UI and Material together breaks column headers

3 participants