[test][Autocomplete] Make virtualize regression screenshots deterministic#44425
Merged
DiegoAndai merged 2 commits intomui:masterfrom Nov 18, 2024
Merged
[test][Autocomplete] Make virtualize regression screenshots deterministic#44425DiegoAndai merged 2 commits intomui:masterfrom
DiegoAndai merged 2 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-44425--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Nov 15, 2024
Member
mnajdova
left a comment
There was a problem hiding this comment.
Nice, I've missed while reviewing the fact that there is a random function while generating the regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An oversight of #44382. The regression test was not deterministic, so the screenshots were unstable. This fixes it by creating the options deterministically while maintaining a similar behavior from the demo.