[docs][Autocomplete] Fix virtualization demo#44382
Conversation
Netlify deploy previewhttps://deploy-preview-44382--material-ui.netlify.app/ Bundle size report |
| return result; | ||
| } | ||
|
|
||
| const StyledPopper = styled(Popper)({ |
There was a problem hiding this comment.
How is this change relevant to the PR?
There was a problem hiding this comment.
I brought it back in d4ac56d. The idea was to simplify the demo and keep the base listbox styles, but I reconsidered and it's better to keep the PR smaller and only with the required changes 👍🏼
There was a problem hiding this comment.
It wouldn't have worked, it needs padding: 0 and margin: 0, it would break without:
|
The demo's preview is being removed because it now surpasses the line limit: it has 19 lines, and the line limit for previews is 16. Should we accept this, or do we want to skip the limit for this demo? @siriwatknp @mnajdova |
|
I think it's better to comply with the max lines rule for consistency, so the preview will now be hidden. |
mnajdova
left a comment
There was a problem hiding this comment.
Looks good, I noticed that for some reason the CodeSandbox export throws an error:
×
TypeError
(0 , $csb__eMediaQuery.unstable_createUseMediaQuery) is not a function
Stackblitz is working as expected. We could investigate it separately.
|
@mnajdova seems like Codesandbox is using a stale version of |
| return result; | ||
| } | ||
|
|
||
| const StyledPopper = styled(Popper)({ |
There was a problem hiding this comment.
It wouldn't have worked, it needs padding: 0 and margin: 0, it would break without:
| }); | ||
|
|
||
| const OPTIONS = Array.from(new Array(10000)) | ||
| .map(() => random(10 + Math.ceil(Math.random() * 20))) |
There was a problem hiding this comment.
This doesn't work, unstable screenshots https://app.argos-ci.com/mui/material-ui/builds/33543/119540069.
Fix the virtualization demo options style, which should've used
slotProps.listbox.componentinstead ofslots.listbox, as we wish to keep the original listbox style.Closes #44329
Closes #44189
Preview: https://deploy-preview-44382--material-ui.netlify.app/material-ui/react-autocomplete/#virtualization