Skip to content

[material-ui] Fix default props theme scoping#44340

Merged
siriwatknp merged 3 commits intomui:masterfrom
siriwatknp:fix/mui-defaultprops-theme-scoping
Nov 11, 2024
Merged

[material-ui] Fix default props theme scoping#44340
siriwatknp merged 3 commits intomui:masterfrom
siriwatknp:fix/mui-defaultprops-theme-scoping

Conversation

@siriwatknp
Copy link
Copy Markdown
Member

@siriwatknp siriwatknp commented Nov 7, 2024

closes #44334

Tested locally using the CodeSandbox build, the change works as expected but not with CodeSandbox web (something is wrong from their side).

@siriwatknp siriwatknp requested a review from DiegoAndai November 7, 2024 08:11
@siriwatknp siriwatknp added type: regression A bug, but worse, it used to behave as expected. package: material-ui v6.x labels Nov 7, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Nov 7, 2024

Netlify deploy preview

https://deploy-preview-44340--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against a4fdb6c

@siriwatknp siriwatknp self-assigned this Nov 7, 2024
Comment thread packages/mui-system/src/ThemeProvider/ThemeProvider.js
@siriwatknp siriwatknp requested a review from DiegoAndai November 8, 2024 02:07
@siriwatknp siriwatknp merged commit eded485 into mui:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: regression A bug, but worse, it used to behave as expected. v6.x

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[material-ui] defaultProps ignored when using theme scoping

3 participants