Skip to content

[docs][material-ui] Fix typo in typography theme set up for templates#44338

Merged
ZeeshanTamboli merged 9 commits intomui:masterfrom
qburst:fix--44324
Nov 11, 2024
Merged

[docs][material-ui] Fix typo in typography theme set up for templates#44338
ZeeshanTamboli merged 9 commits intomui:masterfrom
qburst:fix--44324

Conversation

@navedqb
Copy link
Copy Markdown
Contributor

@navedqb navedqb commented Nov 7, 2024

Fixes #44324

Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
fix: typo in mui typography theme set up
@navedqb navedqb changed the title Fix 44324 fix: typo in mui typography theme set up Nov 7, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Nov 7, 2024

Netlify deploy preview

https://deploy-preview-44338--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f1180a7

@ZeeshanTamboli ZeeshanTamboli changed the title fix: typo in mui typography theme set up [docs][material-ui] Fix typo in typography theme set up for templates Nov 7, 2024
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation. package: material-ui design This is about UI or UX design, please involve a designer. labels Nov 7, 2024
Copy link
Copy Markdown
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navedqb Can you fix the CI by updating the TypeScript demo using pnpm docs:typescript:formatted and format using Prettier (pnpm prettier)?

Comment thread docs/data/material/getting-started/templates/shared-theme/themePrimitives.ts Outdated
@ZeeshanTamboli ZeeshanTamboli added the type: bug It doesn't behave as expected. label Nov 9, 2024
@ZeeshanTamboli
Copy link
Copy Markdown
Member

Merging with the latest master branch could fix the CI.

Copy link
Copy Markdown
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ZeeshanTamboli ZeeshanTamboli merged commit 9fbc6f9 into mui:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] MUI free template has a typo in Typography's theme set up

3 participants