[FormControlLabel][docs] Don't use unintuitive label position on chec…#44119
Merged
mnajdova merged 1 commit intomui:masterfrom Oct 17, 2024
Merged
Conversation
…kbox, radio and switch demos
Netlify deploy previewhttps://deploy-preview-44119--material-ui.netlify.app/ Bundle size report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44107.
Based on SC 3.3.2 the bottom and end position are the only one that should be allowed for checkboxes and radios. Having the top or left placement is unintuitive, and we should not give the developers instructions on using them.
Considering the FormControlLabel is a generic component, there is no easy way to restrict the values, but the least we can do is not teach people how to create nonaccessible UIs.
Preview: https://deploy-preview-44119--material-ui.netlify.app/material-ui/react-checkbox/#label-placement