[material-ui][Chip] Correct deleteIconColorPrimary and deleteIconColorSecondary class descriptions#41231
Conversation
sai6855
commented
Feb 22, 2024
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-41231--material-ui.netlify.app/ Bundle size report |
| /** Styles applied to the deleteIcon element if `size="medium"`. */ | ||
| deleteIconMedium: string; | ||
| /** Styles applied to the deleteIcon element if `color="primary"` and `variant="filled"`. */ | ||
| /** Styles applied to the deleteIcon element if `color="primary"`. */ |
There was a problem hiding this comment.
deleteIconColorPrimary is applied to the deleteIcon irrespective of the variant value, so I've removed variant='filled' from the description.
there is already a class called deleteIconFilledColorPrimary combining color and variant
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Nice catch! Looks like it was just copied over. Once the merge unfreezes for the current release, I'll go ahead and merge it.
Just a reminder, make sure the product comes first in the PR title, followed by the component name: [product-name][component-name].
deleteIconColorPrimary and deleteIconColorSecondary class descriptiondeleteIconColorPrimary and deleteIconColorSecondary class descriptions
Noted. |
…olorSecondary` class descriptions (mui#41231)