Skip to content

[material-ui][Slider] Deprecate components and componentProps props for v6#40777

Merged
DiegoAndai merged 8 commits intomui:masterfrom
lhilgert9:mui-material/slider-v6-component-deprecation
Feb 22, 2024
Merged

[material-ui][Slider] Deprecate components and componentProps props for v6#40777
DiegoAndai merged 8 commits intomui:masterfrom
lhilgert9:mui-material/slider-v6-component-deprecation

Conversation

@lhilgert9
Copy link
Copy Markdown
Contributor

@lhilgert9 lhilgert9 commented Jan 24, 2024 •
edited
Loading

Part of: #40417

Deprecate components and componentsProps props in favor of slots and slotProps respectively.

There wasn't much to do😊.

@mui-bot
Copy link
Copy Markdown

mui-bot commented Jan 24, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c6fec4b

@danilo-leal danilo-leal added scope: slider Changes related to the slider. package: material-ui labels Jan 24, 2024
@lhilgert9 lhilgert9 marked this pull request as ready for review February 21, 2024 18:03
@DiegoAndai DiegoAndai mentioned this pull request Feb 21, 2024
Closed
@DiegoAndai DiegoAndai self-requested a review February 21, 2024 20:43
DiegoAndai
DiegoAndai reviewed Feb 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lhilgert9, looks good!

Just one comment.

Comment thread packages/mui-material/src/Slider/Slider.d.ts Outdated
@lhilgert9
Copy link
Copy Markdown
Contributor Author

lhilgert9 commented Feb 22, 2024

Hey @lhilgert9, looks good!

Just one comment.

Done👍🏽

DiegoAndai
DiegoAndai approved these changes Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhilgert9! 🎉

@DiegoAndai DiegoAndai merged commit c0eb421 into mui:master Feb 22, 2024
@DiegoAndai DiegoAndai mentioned this pull request Feb 26, 2024
Closed
17 tasks
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@lhilgert9 @mnajdova
[material-ui][Slider] Deprecate components and componentProps props f…
f51feda 
…or v6 (mui#40777)
@skmanoj322
Copy link
Copy Markdown
Contributor

skmanoj322 commented Mar 11, 2024

hey @lhilgert9 right now i am trying to implement the same for badge. In codemod i created actual.js but i am not able to run
actual.js. I read CONTRIBUTING.md in codemod it says to us these command

node packages/mui-codemod/codemod deprecations/accordion-props packages/mui-codemod/src/deprecations/accordion-props/test-cases/theme.actual.js

so i used the command
node packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js
and it threw me error stating canot use import statement outside a module.

can you tell me the right command to test actual.js

@lhilgert9
Copy link
Copy Markdown
Contributor Author

lhilgert9 commented Mar 11, 2024

Hey @skmanoj322, yes, i had my difficulties with it at the beginning too. But it should work for you with the following command: node packages/mui-codemod/codemod deprecations/badge-props packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js 🚀
If I can help you in any other way, you are welcome to write again😊

@lhilgert9 lhilgert9 deleted the mui-material/slider-v6-component-deprecation branch April 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees

No one assigned

Labels

scope: slider Changes related to the slider.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lhilgert9 @mui-bot @skmanoj322 @DiegoAndai @danilo-leal