[docs][joy-ui] Add use-count-up integration with the Circular Progress#38952
Merged
mnajdova merged 7 commits intomui:masterfrom Sep 18, 2023
Merged
Conversation
<!-- Thanks so much for your PR, your contribution is appreciated! ❤️ --> - [x] I have followed (at least) the [PR section of the contributing guide](https://github.com/mui/material-ui/blob/HEAD/CONTRIBUTING.md#sending-a-pull-request).
xcode-it
commented
Sep 13, 2023
Netlify deploy previewBundle size report |
1 task
use-count-up intergration with the Circular Progress
danilo-leal
approved these changes
Sep 13, 2023
Collaborator
danilo-leal
left a comment
There was a problem hiding this comment.
Sweet, thanks for persisting with this! Looks great to me!
Would still wait for either @siriwatknp's or @DiegoAndai's (given you were seeing some flaky test issues with this integration) perspective before merging, though. :)
Member
|
We will skip the Argos test to avoid the flaky test from the Linear Progress example: #38969. We should do the same here. It's a new snapshot, so I don't know if that will be a problem, but let's try 😅 |
…ular-progress-count-up-feature-v2
siriwatknp
approved these changes
Sep 15, 2023
Member
siriwatknp
left a comment
There was a problem hiding this comment.
👏 Thanks again @anon-phantom
use-count-up intergration with the Circular Progressuse-count-up integration with the Circular Progress
mnajdova
approved these changes
Sep 18, 2023
danilo-leal
pushed a commit
to siriwatknp/material-ui
that referenced
this pull request
Sep 18, 2023
christophermorin
pushed a commit
to christophermorin/material-ui
that referenced
this pull request
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38682
https://deploy-preview-38952--material-ui.netlify.app/joy-ui/react-circular-progress/#use-count-up