Skip to content

[website] Add stray design tweaks to the X page#38589

Merged
danilo-leal merged 1 commit intomui:masterfrom
danilo-leal:stray-x-page-improvements
Sep 19, 2023
Merged

[website] Add stray design tweaks to the X page#38589
danilo-leal merged 1 commit intomui:masterfrom
danilo-leal:stray-x-page-improvements

Conversation

@danilo-leal
Copy link
Copy Markdown
Collaborator

@danilo-leal danilo-leal commented Aug 22, 2023

This PR does a slight clean up on some X-page-related styles across all of its sections. Nothing too big, though, mostly color, spacing, and typography. Had a bit of a hard time trying to target some stuff on the Data Grid, though. Wonder how folks would do that.

https://deploy-preview-38589--material-ui.netlify.app/x/

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer. website Pages that are not documentation-related, marketing-focused. labels Aug 22, 2023
@danilo-leal danilo-leal self-assigned this Aug 22, 2023
@mui-bot
Copy link
Copy Markdown

mui-bot commented Aug 22, 2023

Netlify deploy preview

https://deploy-preview-38589--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5b26989

@danilo-leal
Copy link
Copy Markdown
Collaborator Author

@gerdadesign + @zanivan + @noraleonte hey y'all! Would appreciate if you could take a quick look at this one ⎯ it's mostly stray style fixes. It was interesting to experience some of the hardships when trying to customize the Data Grid.

@zanivan
Copy link
Copy Markdown
Collaborator

zanivan commented Sep 7, 2023

Overall, it looks good! I like the way you simplified the <FolderTreeView />

One small thing, not so related to the changes here, but this padding-left on the Rejected chip is really bugging me 😅
Screenshot 2023-09-07 at 10 01 09

Still regarding the chip icons, on the Material design table, the Reject and Open looks a bit off due to its filling. Maybe use the filled icons for Filled and Partially filled too?
Screenshot 2023-09-07 at 10 09 33
Another thing, is that it'd be great to have the chips following the same design as the ones at the Data Grid on the components showcase section

@noraleonte
Copy link
Copy Markdown
Contributor

Awesome! 🎉 Thanks for doing this!
I can only second Victor's point, the padding on the Rejected chip seems off 🤔

Another thing that bothers me a bit is the :hover styling on chips in the DataGrid custom theme section. The grey[100] background seems to create quite a big difference IMO, and considering that it has somewhat of a blue ish tint, it creates a weird contrast on the warmer toned chips (Partially filled, Rejected).

image

Sort of a nitpick, and not related to the changes in this PR, but seemed like the right opportunity to improve this, WDYT?

@danilo-leal
Copy link
Copy Markdown
Collaborator Author

Good call for all of these changes! @noraleonte one thing I'd appreciate your help with is targeting the Data Grid progress bars (not sure if this is the correct term) on the "Filled quantity" column in the hero section ⎯ they don't look horrible on light mode but on dark mode they do 😅 I couldn't figure out how to target them...

Screen Shot 2023-09-07 at 17 52 54

Copy link
Copy Markdown
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement! 🎉 Thanks for picking this up! 🤙

@danilo-leal danilo-leal merged commit fd4e9f7 into mui:master Sep 19, 2023
@danilo-leal danilo-leal deleted the stray-x-page-improvements branch September 19, 2023 12:13
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. website Pages that are not documentation-related, marketing-focused.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants