Skip to content

Fixing #769#770

Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom
andrzejj0:issue-769-segment-utils
Oct 20, 2022
Merged

Fixing #769#770
slawekjaranowski merged 1 commit intomojohaus:masterfrom
andrzejj0:issue-769-segment-utils

Conversation

@andrzejj0
Copy link
Copy Markdown
Contributor

@andrzejj0 andrzejj0 commented Oct 18, 2022

Obvious fix + unit tests.

Please add to the release if still possible.

@andrzejj0
Copy link
Copy Markdown
Contributor Author

@slawekjaranowski

@pzygielo

This comment was marked as off-topic.

@andrzejj0
Copy link
Copy Markdown
Contributor Author

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

Note: "fixing" is not recognized as closing keyword and it does not link PR with issue.

Thanks

@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 20, 2022
@slawekjaranowski
Copy link
Copy Markdown
Member

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests
Note: "fixing" is not recognized as closing keyword and it does not link PR with issue.

keywords can be also used in commit message - not necessary in commit subject 😄

@pzygielo

This comment was marked as off-topic.

@andrzejj0
Copy link
Copy Markdown
Contributor Author

Pls merge 😏

@slawekjaranowski slawekjaranowski merged commit 98c703e into mojohaus:master Oct 20, 2022
@andrzejj0 andrzejj0 deleted the issue-769-segment-utils branch October 20, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unchanged segment == empty if allowMajorUpdates && allowMinorUpdates

3 participants