Adding some of the remaining AbstractVersionDetails methods to the interface#751
Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom Oct 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the caching PR for the reports, I couldn't fail to notice that we're using the AbstractVersionDetails as the interface in many cases whilst the methods could be moved to the API instead.
Reordered some methods in the interface to adhere closer to the AbstractVersionDetails class.
Once this is merged, the AbstractVersionDetails calls could be replaced by VersionDetails.