Issue 342 scm set tag add new elements#694
Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom Sep 17, 2022
Merged
Conversation
daa65e3 to
fd4f0b1
Compare
slawekjaranowski
approved these changes
Sep 17, 2022
Contributor
Author
|
I think the PR removing I'm gonna create a fixing PR right away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is some enhancement of the scm-tag functionality. Whereas it was only possible to add new values to the existing scm subelements, this enhancement adds the possibility to add missing elements as well.
In the code, I've replaced stack usage with reflection in PomHelper, but it doesn't really make a difference (can revert it if necessary, I think it's a question of taste). Plus, encapsulated some implementation details, recursion state (drawback of using recursion), and helper methods within a local class.
It's not fully flexible -- it doesn't allow us to create new elements if also the parent element is missing -- but since it's not XSD-aware, it wouldn't know where to put the new element :)