Skip to content

Fixed #682: Restoring the ability to provide an empty "newVersion" argument#683

Merged
slawekjaranowski merged 1 commit intomojohaus:masterfrom
andrzejj0:issue-682-set-property-allow-null-version
Sep 12, 2022
Merged

Fixed #682: Restoring the ability to provide an empty "newVersion" argument#683
slawekjaranowski merged 1 commit intomojohaus:masterfrom
andrzejj0:issue-682-set-property-allow-null-version

Conversation

@andrzejj0
Copy link
Copy Markdown
Contributor

Looks like folks were using the ability to clear a property value. Restoring it + updating the unit test suite.

@andrzejj0 andrzejj0 force-pushed the issue-682-set-property-allow-null-version branch from e654b41 to 28cee94 Compare September 9, 2022 05:09
@andrzejj0
Copy link
Copy Markdown
Contributor Author

@slawekjaranowski please review

Comment thread src/test/java/org/codehaus/mojo/versions/SetPropertyMojoTest.java
@andrzejj0 andrzejj0 force-pushed the issue-682-set-property-allow-null-version branch from 28cee94 to 0c034a3 Compare September 9, 2022 08:36
@andrzejj0
Copy link
Copy Markdown
Contributor Author

Could you restart the jobs?

@slawekjaranowski slawekjaranowski added this to the next-release milestone Sep 12, 2022
@slawekjaranowski slawekjaranowski linked an issue Sep 12, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski merged commit fb89924 into mojohaus:master Sep 12, 2022
@andrzejj0 andrzejj0 deleted the issue-682-set-property-allow-null-version branch September 12, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: set-property should allow clearing properties

2 participants