Skip to content

Fix ClassCastException#2962

Merged
TimvdLippe merged 2 commits intomockito:mainfrom
jfrantzius:main
Apr 9, 2023
Merged

Fix ClassCastException#2962
TimvdLippe merged 2 commits intomockito:mainfrom
jfrantzius:main

Conversation

@jfrantzius
Copy link
Copy Markdown
Contributor

@jfrantzius jfrantzius commented Apr 3, 2023

Adds support for concrete classes with parameterized super-classes.
Fixes #2958

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 95.34% and project coverage change: +0.03 🎉

Comparison is base (f9fbf50) 85.70% compared to head (f6eecf1) 85.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2962      +/-   ##
============================================
+ Coverage     85.70%   85.74%   +0.03%     
- Complexity     2865     2870       +5     
============================================
  Files           325      325              
  Lines          8696     8713      +17     
  Branches       1074     1076       +2     
============================================
+ Hits           7453     7471      +18     
  Misses          966      966              
+ Partials        277      276       -1     
Impacted Files Coverage Δ
...ion/injection/filter/TypeBasedCandidateFilter.java 96.25% <95.34%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jfrantzius
Copy link
Copy Markdown
Contributor Author

@TimvdLippe WDYT?

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@TimvdLippe TimvdLippe merged commit 84a5eee into mockito:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassCastException when combining InjectMocks with generified Mock field

3 participants