CI on Android API level 33 for Java 11 compatibility testing#2899
Merged
TimvdLippe merged 3 commits intomockito:mainfrom Feb 4, 2023
TWiStErRob:android33
Merged
CI on Android API level 33 for Java 11 compatibility testing#2899TimvdLippe merged 3 commits intomockito:mainfrom TWiStErRob:android33
TimvdLippe merged 3 commits intomockito:mainfrom
TWiStErRob:android33
Conversation
Codecov ReportBase: 85.65% // Head: 85.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=========================================
Coverage 85.65% 85.65%
Complexity 2847 2847
=========================================
Files 325 325
Lines 8623 8623
Branches 1060 1060
=========================================
Hits 7386 7386
Misses 964 964
Partials 273 273 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
@TimvdLippe @reta as promised on #2893 (comment), still no inter-dependency with #2894. |
reta
approved these changes
Feb 3, 2023
4 tasks
TWiStErRob
commented
Feb 6, 2023
Comment on lines
+98
to
+104
| include: | ||
| # Minimum supported | ||
| - android-api: 26 | ||
| android-image-type: default | ||
| # Maximum available | ||
| - android-api: 33 | ||
| android-image-type: google_apis |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #2893 (comment)
Goal
Adding API 33 to the testing suite, because it might bring significant changes which affect the internals of Mockito.
Additional changes
include:because Google doesn't supplydefaultemulator images for 32 and 33. We found out the hard way here.mockito/.github/workflows/ci.yml
Line 146 in e978455
and
mockito/gradle/java-library.gradle
Lines 17 to 18 in e978455
Motivation
Android 13 / API 33 introduced Java 11 support:
https://developer.android.com/about/versions/13/features#core-libraries
https://android-developers.googleblog.com/2022/08/android-13-is-in-aosp.html
https://vived.io/android-gets-support-for-jdk-11-jvm-weekly-100/
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant