Skip to content

Fixes #1898 : Return mock name from toString method for deep stub mocks#1942

Merged
TimvdLippe merged 1 commit intomockito:release/3.xfrom
akluball:deep-stubs-tostring-return-mock-name
May 31, 2020
Merged

Fixes #1898 : Return mock name from toString method for deep stub mocks#1942
TimvdLippe merged 1 commit intomockito:release/3.xfrom
akluball:deep-stubs-tostring-return-mock-name

Conversation

@akluball
Copy link
Copy Markdown
Contributor

Return mock name from toString for deep stub mocks. It was previously returning null.

Fixes #1898

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2020

Codecov Report

Merging #1942 into release/3.x will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1942   +/-   ##
==============================================
  Coverage          86.67%   86.68%           
- Complexity          2526     2527    +1     
==============================================
  Files                318      318           
  Lines               6650     6652    +2     
  Branches             832      833    +1     
==============================================
+ Hits                5764     5766    +2     
  Misses               685      685           
  Partials             201      201           
Impacted Files Coverage Δ Complexity Δ
...rnal/stubbing/defaultanswers/ReturnsDeepStubs.java 97.91% <100.00%> (+0.09%) 17.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6620170...2e98392. Read the comment docs.

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@TimvdLippe TimvdLippe merged commit 3c10616 into mockito:release/3.x May 31, 2020
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RETURNS_DEEP_STUBS override a mock's toString to null

3 participants