Update report message to use any() instead of anyObject()#1931
Merged
TimvdLippe merged 1 commit intomockito:release/3.xfrom May 31, 2020
Merged
Update report message to use any() instead of anyObject()#1931TimvdLippe merged 1 commit intomockito:release/3.xfrom
TimvdLippe merged 1 commit intomockito:release/3.xfrom
Conversation
because anyObject() has already been deprecated, it would be better to push to use any()
Codecov Report
@@ Coverage Diff @@
## release/3.x #1931 +/- ##
==============================================
Coverage 86.67% 86.67%
Complexity 2526 2526
==============================================
Files 318 318
Lines 6650 6650
Branches 832 832
==============================================
Hits 5764 5764
Misses 685 685
Partials 201 201
Continue to review full report at Codecov.
|
epeee
pushed a commit
to epeee/mockito
that referenced
this pull request
Jun 22, 2020
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this pull request
Jun 22, 2022
Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this pull request
Jun 22, 2022
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR JanusGraph#2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
9 tasks
FlorianHockmann
added a commit
to FlorianHockmann/janusgraph
that referenced
this pull request
Jun 29, 2022
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR JanusGraph#2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
FlorianHockmann
added a commit
to JanusGraph/janusgraph
that referenced
this pull request
Jun 30, 2022
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR #2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
anyObject()has already been deprecated, it would be better to push to useany()instead.check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant