Replace core::WrapAlgorithm enum with WrapAlgorithm trait#357
Merged
Replace core::WrapAlgorithm enum with WrapAlgorithm trait#357
core::WrapAlgorithm enum with WrapAlgorithm trait#357Conversation
99e3d8d to
530254f
Compare
This introduces a `textwrap::wrap_algorithms` module where the `wrap_first_fit` and `wrap_optimal_fit` functions now live. A new `WrapAlgorithm` trait replaces the old enum. This allows for arbitrary wrapping algorithms to be plugged into the library. We should also be able to change the return type from `Vec<&[Word]>` to `Iterator<Item = Word>` and thus implement streaming wrapping for the first-fit in the future. Fixes #325.
530254f to
d6b2791
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a
textwrap::wrap_algorithmsmodule where thewrap_first_fitandwrap_optimal_fitfunctions now live.A new
WrapAlgorithmtrait replaces the old enum. This allows for arbitrary wrapping algorithms to be plugged into the library. We should also be able to change the return type fromVec<&[Word]>toIterator<Item = Word>and thus implement streaming wrapping for the first-fit in the future.Fixes #325.