Make indent faster by preallocating the output string#354
Merged
Conversation
On my system, it takes just under 2 microseconds to indent the 50
lines in the ~2 KB text:
% cargo criterion --bench indent
indent time: [1.8829 us 1.8891 us 1.8948 us]
indentindent
This makes the function about 20% faster:
% cargo criterion --bench indent
indent time: [1.4647 us 1.4670 us 1.4698 us]
change: [-23.426% -22.816% -22.328%] (p = 0.00 < 0.05)
Performance has improved.
26f7857 to
19bb2ef
Compare
indentindent faster by preallocating the output string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, it took just under 2 microseconds to indent a ~2 KB text with 50 lines:
Preallocating the output string makes the function about 20% faster: