Fix #20287: Add flexible types to Quotes library#20293
Conversation
|
Hi @nicolasstucki, do you have any idea why the extractor for |
|
This should probably be included in 3.5 as it is a part of #18112. Specifically, the changes in the TASTy format require this change in the reflection API. |
|
The core meeting decided to take this PR in on 3.5.0. |
jchyb
left a comment
There was a problem hiding this comment.
LGTM! The only thing missing here is the scaladoc for FlexibleTypeMethods, but this can be done in a separate PR, and with another review cycle we may not meet the deadline today for the cutoff for 3.5.0
Nicolas is unavailable and all of the changes and concerns raised by him were resolved.
hamzaremmal
left a comment
There was a problem hiding this comment.
Apart from some observations, LGTM
| ConstantType(StringConstant("hello")) | ||
|
|
||
| Inlined(None, Nil, Apply(Select(Literal(StringConstant("world")), "trim"), Nil)) | ||
| FlexibleType(TypeRef(ThisType(TypeRef(NoPrefix(), "lang")), "String")) |
There was a problem hiding this comment.
Mmmmh, I'm wondering why we don't have the java prefix here for java.lang.String.
We do have it for the second type below 🤔
There was a problem hiding this comment.
I guess because it is from a Java method?
Fix #20287
To fix the missing case, we have to add flexible types to
Quoteslibrary.