Remove params parameter from exec function#173
Merged
theogravity merged 2 commits intokriasoft:masterfrom Jul 11, 2023
ar1k:remove-params-exec
Merged
Remove params parameter from exec function#173theogravity merged 2 commits intokriasoft:masterfrom ar1k:remove-params-exec
params parameter from exec function#173theogravity merged 2 commits intokriasoft:masterfrom
ar1k:remove-params-exec
Conversation
Collaborator
|
Thanks, looks good. I'm going to bump a major version as this is a breaking change even if it's invalid. |
theogravity
approved these changes
Jul 11, 2023
|
Could this be documented in the CHANGELOG.md file ? |
Collaborator
|
It is documented, but should have been called out as a breaking change. I'll update this. This project follows semver rules. Assume any major version bump may have a breaking change. |
|
Thank you for the updated changelog, it will make it easier for people to update with confidence 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
execis not a part ofStatement(https://github.com/TryGhost/node-sqlite3/blob/master/src/statement.cc#L17), but a part ofDatabaseitself (https://github.com/TryGhost/node-sqlite3/blob/master/src/database.cc#L21), it does not supportparamsbinding. So, we should not exposeparamsto theexecpublic interface here. Also, this corresponds tonode-sqlite3API docs (https://github.com/TryGhost/node-sqlite3/wiki/API#execsql--callback).