Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jsdoc/jsdoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.6.5
Choose a base ref
...
head repository: jsdoc/jsdoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.6.6
Choose a head ref
  • 2 commits
  • 8 files changed
  • 1 contributor

Commits on Sep 20, 2020

  1. fix: correctly track interface members 

    When an interface is a) defined as an ES2015 class and b) assigned to a variable, JSDoc sometimes used the wrong `longname` and `memberof` for members of the interface (specifically, for instance properties).

The root cause was that we weren't resolving `this` correctly within this type of interface. As a result, if you added a JSDoc comment to something like `this.foo = 'bar'`, the doclet for `this.foo` had the wrong `longname` and `memberof`.

Fixing that issue uncovered another issue: When we merged the constructor's doclet with the interface's doclet, we preferred the constructor's doclet. However, the constructor's doclet used the wrong `kind` in this case; we already had code to fix up the `longname` and `memberof` of the combined doclet, but not the `kind`. The fix was to prefer the interface's doclet for all properties.
    @hegemonic
    hegemonic committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    95e3192 View commit details
    Browse the repository at this point in the history

  2. 3.6.6

    @hegemonic
    hegemonic committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    3f5c462 View commit details
    Browse the repository at this point in the history
Loading