Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jsdoc/jsdoc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.6.4
Choose a base ref
...
head repository: jsdoc/jsdoc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.6.5
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Jul 22, 2020

  1. fix: prevent circular refs when params have the same type expression 

    Catharsis caches parse results by default; if you parse the same type expression twice, with the same options, you get the same object each time.

When the user passes the `--debug` flag, we expose the parsed type for each parameter as an enumerable property of the doclet. If two parameters used the same type expression, the resulting doclet could contain a circular reference.

This change disables the Catharsis cache, so that Catharsis returns a new object for each parsed type, which prevents circular references. As a result, this change fixes an issue with the `-X` flag, and with some JSDoc templates.
    @hegemonic
    hegemonic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a59b5cd View commit details
    Browse the repository at this point in the history

  2. 3.6.5

    @hegemonic
    hegemonic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    ef05a69 View commit details
    Browse the repository at this point in the history
Loading