Composite: don't write to null pixels#1226
Merged
hipstersmoothie merged 1 commit intoMay 11, 2023
Merged
Conversation
Contributor
|
🚀 PR was released in |
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 29, 2024
This was referenced Aug 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
This fixes a bug with the composite function which would write garbage data to a pixel at 0, 0 when the target pixel doesn't exist, which can happen when:
This is because
getPixelIndex()returns -1 when using EDGE_CROP which didn't get checked for. So when writing to the target the red channel maps to -1 in the destination buffer, which gets discarded silently (Buffers surprisingly don't throw when you do this) and then the GBA parts of the source get written to the RGB channels on the target.You can actually see it in the testing image I fixed for this PR: The old "correct" one has a random, off color pixel in the top left, the new one doesn't.
What else might be affected
Should not affect anything.
Tasks
jimp.d.ts