Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stenciljs/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.8.1
Choose a base ref
...
head repository: stenciljs/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.8.2
Choose a head ref
  • 20 commits
  • 42 files changed
  • 7 contributors

Commits on Dec 4, 2023

  1. fix(compiler): make sure typesDir exist before writing to it (#5109)

    * fix(compiler): make sure typesDir exist before writing to it
    
    fixes #5091 / STENCIL-1024
    
    * make sure errors are propagated
    
    * resolve race condition in directory creation
    
    * update unit test
    
    * revert public type changes
    christian-bromann authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9e4e27e View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. chore(esbuild): ensure base esbuild options are set for compiler (#5132)

    This adds the `getBaseEsbuildOptions` function to the Esbuild
    configuration for the `compiler/` bundle. This ensures that the
    following options are set consistently:
    
    - [`logLevel`](https://esbuild.github.io/api/#log-level)
    - [`legalComments`](https://esbuild.github.io/api/#legal-comments)
    - [`bundle`](https://esbuild.github.io/api/#bundle)
    
    This was accidentally omitted from #5027.
    alicewriteswrongs authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e78a9a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. fix(runtime): relocate slotted content when slot parent element tag c…

    …hanges (#5120)
    
    * fix(runtime): re-relocate slot if parent element's tagname changes
    
    If a slot is located in an element and that element's tag is dynamically changed (e.g. from `p` to `span`), we need to re-relocate the slot on re-render
    
    STENCIL-672: slot element loses its parent reference and disappears when its parent is rendered conditionally
    
    Fixes: #4284, #3913
    
    * add e2e tests
    
    * code documentation
    
    * put changes behind slot fix flag
    
    * resolve new SNC
    
    * Apply suggestions from code review
    
    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    
    ---------
    
    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    tanner-reits and rwaskiewicz authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4303d6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    735d45a View commit details
    Browse the repository at this point in the history
  3. fix(runtime): hide slotted content with no destination in scoped comp…

    …onents (#5135)
    
    * fix(runtime): re-relocate slot if parent element's tagname changes
    
    If a slot is located in an element and that element's tag is dynamically changed (e.g. from `p` to `span`), we need to re-relocate the slot on re-render
    
    STENCIL-672: slot element loses its parent reference and disappears when its parent is rendered conditionally
    
    Fixes: #4284, #3913
    
    * add e2e tests
    
    * code documentation
    
    * put changes behind slot fix flag
    
    * resolve new SNC
    
    * reset `hidden` state of nodes on relocate
    
    It is possible for slotted content to still be invisible in the DOM if the slot was not rendered on the first render. This commit resets the `hidden` attribute of a node on successful relocation.
    
    STENCIL-1053
    
    * hide slot content without a home in `scoped` components
    
    Hides any content that is projected through to a Stencil component that does not have a destination slot. Only for `scoped` components.
    
    Fixes #2877
    
    STENCIL-938
    
    * add e2e tests for hiding content without a slot
    
    * revert karma config
    
    * PR feedback
    
    Co-authored-by: Christian Bromann <git@bromann.dev>
    
    ---------
    
    Co-authored-by: Christian Bromann <git@bromann.dev>
    tanner-reits and christian-bromann authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    77bce27 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. chore(deps): update dependency postcss to v8.4.32 (#5138)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    26a3e7e View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency cspell to v8.1.0 (#5139)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    81734b7 View commit details
    Browse the repository at this point in the history
  3. chore(deps): update dependency eslint to v8.55.0 (#5140)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2e2252c View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency eslint-config-prettier to v9.1.0 (#5141)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    aa4046e View commit details
    Browse the repository at this point in the history
  5. chore(deps): update dependency @types/node to v20.10.3 (#5137)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    357def5 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. chore(esbuild): build mock-doc with esbuild (#5012)

    This adds support for building the mock-doc top-level-module using
    esbuild.
    
    STENCIL-1009: port mock-doc bundle to esbuild
    alicewriteswrongs authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3c57875 View commit details
    Browse the repository at this point in the history
  2. fix(testing): make Puppeteer an optional dependency (#5145)

    Currently it seems required to have Puppeteer installed to build a Stencil component. It seems that the compiler imports parts of the testing module to compile a project which causes "/testing/puppeteer/puppeteer-declarations.d.ts" to be loaded.
    
    To solve the type dependency the easiest is to add a Rollup plugin that simply adds a "@ts-ignore" before the import. If Puppeteer is not installed, it will not throw any errors, if it is installed, all types are propagated correctly.
    
    STENCIL-881
    fixes #4526
    christian-bromann authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    43cf0dc View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. chore(deps): update dependency @types/node to v20.10.4 (#5150)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d6d5cda View commit details
    Browse the repository at this point in the history
  2. chore(deps): update typescript-eslint to v6.13.2 (#5153)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0868b00 View commit details
    Browse the repository at this point in the history
  3. chore(deps): update dependency puppeteer to v21.6.0 (#5154)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    15eb129 View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency terser to v5.26.0 (#5156)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    fa5e9f6 View commit details
    Browse the repository at this point in the history
  5. chore(deps): update dependency cspell to v8.1.3 (#5151)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    476c7b6 View commit details
    Browse the repository at this point in the history
  6. fix(runtime): update textContent patch to mimic Shadow Root (#5146)

    * only patch scoped components
    
    * patch `textContent` for `scoped` components
    
    This commit updates our patch for `textContent` to mimic the Shadow Root implementation
    
    Fixes: #3977
    
    STENCIL-687
    
    * fix e2e tests for new implementation
    
    * ignore comment nodes in getter
    
    * fix issue with removing multiple nodes in slot for setter
    
    * add e2e tests for `textContent` patch
    
    * re-add build flag checks
    tanner-reits authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    55c56d6 View commit details
    Browse the repository at this point in the history
  7. fix(compiler): make style getter behavior consistent between default …

    …and native components (#5144)
    
    * fix(compiler): make style getter behavior consistent between default and native components
    
    * apply changes for multi mode styles
    
    * add comments that order of ifs must match
    christian-bromann authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    6abe250 View commit details
    Browse the repository at this point in the history
  8. Release v4.8.2 (#5157)

    * v4.8.2
    
    * Update CHANGELOG.md
    
    ---------
    
    Co-authored-by: christian-bromann <christian-bromann@users.noreply.github.com>
    Co-authored-by: Christian Bromann <git@bromann.dev>
    3 people authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    70884f8 View commit details
    Browse the repository at this point in the history
Loading