Conversation
wooorm
reviewed
Apr 20, 2022
43081j
approved these changes
Apr 21, 2022
Collaborator
43081j
left a comment
There was a problem hiding this comment.
looks good to me.
is there any easy way to get to the right coveralls page? maybe we can add a badge or something? or make CI output it?
Collaborator
Author
|
Coveralls should write the coverage as a check for each PR, and error if it is reduced. My guess is that the lack of a baseline for the master branch makes coveralls skip writing the check. |
Collaborator
Author
|
I have added a badge in #517 |
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211