Use tomli in place of unmaintained toml package#629
Merged
hhatto merged 1 commit intohhatto:mainfrom Oct 12, 2022
Merged
Conversation
Use the modern `tomli` TOML parser instead of `toml`. The latter package is no longer maintained and does not support TOML 1.0.
Codecov ReportBase: 97.91% // Head: 97.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 97.91% 97.87% -0.05%
==========================================
Files 1 1
Lines 2399 2399
==========================================
- Hits 2349 2348 -1
- Misses 50 51 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
Ping. |
Owner
|
@mgorny merged this pr. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the modern
tomliTOML parser instead oftoml. The latterpackage is no longer maintained and does not support TOML 1.0.
Open question:
tomlidoesn't support Python 2. Do you prefer if I removed Python 2 support entirely, did some conditionals to supporttomlfallback on Python 2 or perhaps simply ignored missingpyproject.tomlconfig support in Python 2 and skipped respective tests?