Skip to content

[core,api,auth: Choose executor based on need for thread affinity#9504

Merged
larry-safran merged 4 commits intogrpc:masterfrom
larry-safran:executor-use-rollback
Sep 3, 2022
Merged

[core,api,auth: Choose executor based on need for thread affinity#9504
larry-safran merged 4 commits intogrpc:masterfrom
larry-safran:executor-use-rollback

Conversation

@larry-safran
Copy link
Copy Markdown
Contributor

@larry-safran larry-safran commented Sep 1, 2022

[core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681

…metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
@larry-safran larry-safran self-assigned this Sep 1, 2022
@larry-safran larry-safran marked this pull request as ready for review September 1, 2022 23:53
@larry-safran larry-safran requested a review from ejona86 September 1, 2022 23:53
@larry-safran larry-safran changed the title Executor use rollback [core,api,auth: Choose executor based on need for thread affinity Sep 1, 2022
Comment thread auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java Outdated
Comment thread auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java Outdated
Comment thread auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java Outdated
Comment thread auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java Outdated
Comment thread core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java Outdated
@ejona86
Copy link
Copy Markdown
Member

ejona86 commented Sep 2, 2022

Reverted

Did you forget to push the change? If you are still working on it that is fine; just want to make sure we aren't each waiting for the other.

@larry-safran larry-safran requested a review from ejona86 September 2, 2022 21:36
Comment thread auth/src/main/java/io/grpc/auth/GoogleAuthLibraryCallCredentials.java Outdated
@larry-safran larry-safran merged commit c27f2d5 into grpc:master Sep 3, 2022
@larry-safran larry-safran deleted the executor-use-rollback branch September 3, 2022 04:55
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Sep 7, 2022
…pc#9504)

* core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Sep 7, 2022
…pc#9504)

* core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
larry-safran added a commit that referenced this pull request Sep 12, 2022
) (#9525)

* core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
larry-safran added a commit that referenced this pull request Sep 12, 2022
) (#9524)

* core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
…pc#9504)

* core,api,auth: Choose the callOptions executor when applying request metadata to credentials during newStream based upon whether AppEngineCredentials are being used as they require a specific thread to do the processing.

Add an interface to differentiate whether the specific thread is needed.

Fixes b/244209681
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants