netty: allow to use bandwidth delay product#6979
Conversation
ejona86
left a comment
There was a problem hiding this comment.
I still need to look at this more, but one of my comments seems good to send now.
The PR description says, "force send WINDOW__UPDATE with bdp ping" but it appears the code is taking the "avoid sending a PING when it will cause a problem" approach.
| .initialWindowSize(handler.connection().connectionStream()); | ||
| } | ||
|
|
||
| static ChannelFutureListener cleanUpTask() { |
There was a problem hiding this comment.
I'm fiercely annoyed by the storage of these handlers and the dance to clean them up. (Not your code, their existence.)
What do you think about having NettyFlowControlTest create a custom ProtocolNegotiator that grabs the GrpcHttp2ConnectionHandler and we pass that to getLatestWindow() (so we would cast to AbstractNettyHandler in this class)?
(I'm also fine at that point trashing this class and just having InternalHandlerSettings)
There was a problem hiding this comment.
done. using ProtocolNegotiator made the conversion very easy.
|
|
||
| @Override | ||
| public void close() { | ||
| delegate.close();; |
Uh oh!
There was an error while loading. Please reload this page.