Skip to content

alts: fix server hang#5900

Merged
carl-mastrangelo merged 2 commits intogrpc:masterfrom
carl-mastrangelo:fixalts2
Jun 19, 2019
Merged

alts: fix server hang#5900
carl-mastrangelo merged 2 commits intogrpc:masterfrom
carl-mastrangelo:fixalts2

Conversation

@carl-mastrangelo
Copy link
Copy Markdown
Contributor

Followup to #5893 which causes a server side hang. This is a hack.

@carl-mastrangelo
Copy link
Copy Markdown
Contributor Author

@jiangtaoli2016 it would be super helpful if there was a mock nanny handshaker so we could test the client and server together. It's pretty painful to test this internally, but then make the changes externally.

Copy link
Copy Markdown
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-mastrangelo carl-mastrangelo merged commit 6e2bb6b into grpc:master Jun 19, 2019
@carl-mastrangelo carl-mastrangelo deleted the fixalts2 branch June 19, 2019 16:25
@jiangtaoli2016
Copy link
Copy Markdown
Contributor

@carl-mastrangelo We have fake handshaker service in gRPC c++ (grpc/test/core/tsi/alts/fake_handshaker/) used by envoy. Can grpc-java use this by running fake handshaker as a separate binary? Or we have to write a fake handshaker in Java.

@carl-mastrangelo
Copy link
Copy Markdown
Contributor Author

@jiangtaoli2016 can it be used in a bazel rule? we could make one here.

@carl-mastrangelo carl-mastrangelo restored the fixalts2 branch August 17, 2019 01:13
@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants