Skip to content

api,stub: Clarify isReady()/onReady() interaction semantics#5799

Merged
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:clarify-onready
May 30, 2019
Merged

api,stub: Clarify isReady()/onReady() interaction semantics#5799
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:clarify-onready

Conversation

@ejona86
Copy link
Copy Markdown
Member

@ejona86 ejona86 commented May 29, 2019

#1549 (comment) brought up that the documentation didn't really specify what it guaranteed.

CC @ulfjack

Copy link
Copy Markdown
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulfjack
Copy link
Copy Markdown
Contributor

ulfjack commented May 29, 2019

Looks good, thanks!

@ejona86 ejona86 merged commit bc2e176 into grpc:master May 30, 2019
@ejona86 ejona86 deleted the clarify-onready branch May 30, 2019 00:28
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants