Remove deprecated enableKeepAlive API from transports#5795
Merged
ejona86 merged 1 commit intogrpc:masterfrom May 28, 2019
Merged
Remove deprecated enableKeepAlive API from transports#5795ejona86 merged 1 commit intogrpc:masterfrom
ejona86 merged 1 commit intogrpc:masterfrom
Conversation
As mentioned in 5188[1], the default used with the enableKeepAlive API conflicted with the default server enforcement. Instead of fixing it, remove it. These APIs were deprecated in v1.3.0 in April 2017. 1. grpc#5188 (comment)
dapengzhang0
approved these changes
May 28, 2019
Member
Author
|
I have migrated all internal users of this API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in 5188[1], the default used with the enableKeepAlive API
conflicted with the default server enforcement. Instead of fixing it,
remove it. These APIs were deprecated in v1.3.0 in April 2017.