api: make LoadBalancer.Helper and Subchannel further non-thread-safe.#5718
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom May 10, 2019
Merged
api: make LoadBalancer.Helper and Subchannel further non-thread-safe.#5718zhangkun83 merged 1 commit intogrpc:masterfrom
zhangkun83 merged 1 commit intogrpc:masterfrom
Conversation
I see more cases of wrapping Helper and Subchannel during the work of XdsLoadBalancer, we will require that all methods that involve mutable state to be called from the Synchronization Context. We will start logging warnings first, and make them throw in a future release. Helper.createSubchannel() is already doing so. This change adds warnings to the other eligible methods. grpc#5015
ejona86
approved these changes
May 10, 2019
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
May 10, 2019
…grpc#5718) I see more cases of wrapping Helper and Subchannel during the work of XdsLoadBalancer, we will require that all methods that involve mutable state to be called from the Synchronization Context. We will start logging warnings first, and make them throw in a future release. Helper.createSubchannel() is already doing so. This change adds warnings to the other eligible methods. grpc#5015
zhangkun83
added a commit
that referenced
this pull request
May 14, 2019
Backport of #5718 I see more cases of wrapping Helper and Subchannel during the work of XdsLoadBalancer, we will require that all methods that involve mutable state to be called from the Synchronization Context. We will start logging warnings first, and make them throw in a future release. Helper.createSubchannel() is already doing so. This change adds warnings to the other eligible methods. #5015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen even more cases of wrapping Helper and Subchannel during
the work of XdsLoadBalancer. To simplify the threading story, we will require
that all methods that involve mutable
state to be called from the Synchronization Context. We will start
logging warnings first, and make them throw in a future release.
Helper.createSubchannel() is already doing so. This change adds
warnings to the other eligible methods.
For more details: see #5015