core: Make OpenCensus tags non-propagating.#5689
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom May 24, 2019
Merged
Conversation
Contributor
Author
zhangkun83
approved these changes
May 9, 2019
dinooliva
approved these changes
May 9, 2019
The `method` and `status` shouldn't be propagated in the first place, but in previous OpenCensus implementation all tags are propagating by default. Now with the TagMetadata it may make sense to change them to local tags. This will be a breaking change to users who depend on the behavior that these tags propagate through process boundaries.
Contributor
Author
|
Just rebased against master. @zhangkun83 please help me trigger Kokoro build again, thanks. |
Contributor
|
@zhangkun83 Merge? |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
methodandstatustags shouldn't be propagated in the first place,but in previous OpenCensus implementation all tags are propagating by
default. Now with the TagMetadata it may make sense to change them to
local tags.
This will be a breaking change to users who depend on the behavior that
these tags propagate through process boundaries.