Skip to content

Commit c985797

Browse files
authored
Upgrade dependencies
All the changes outside libs.versions.toml and examples were because of ErrorProne. It didn't actually find anything to fix; signal vs noise has gotten pretty bad with the newer checks. Status was changed for ErrorProne's SuperCallToObjectMethod. With the old code it didn't notice the trivial implementation. The fail-for-test code wasn't used, so it was easiest to just remove it. Some of the libs had their versions inlined; now that we have :checkForUpdates it isn't much of a risk for versions to diverge when there's only a few artifacts sharing a version. If we need 4+ artifacts to have the same version, then it makes sense to still use a shared version. Dependencies not upgraded: google-auth-libray, mockito, netty, cronet
1 parent 68b14aa commit c985797

File tree

37 files changed

+85
-110
lines changed

37 files changed

+85
-110
lines changed

api/src/main/java/io/grpc/Status.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,6 @@ private byte[] valueAscii() {
234234
}
235235
}
236236

237-
private static final String TEST_EQUALS_FAILURE_PROPERTY = "io.grpc.Status.failOnEqualsForTest";
238-
private static final boolean FAIL_ON_EQUALS_FOR_TEST =
239-
Boolean.parseBoolean(System.getProperty(TEST_EQUALS_FAILURE_PROPERTY, "false"));
240-
241237
// Create the canonical list of Status instances indexed by their code values.
242238
private static final List<Status> STATUS_LIST = buildStatusList();
243239

@@ -662,8 +658,6 @@ private static String parseAsciiStringSlow(byte[] value) {
662658
*/
663659
@Override
664660
public boolean equals(Object obj) {
665-
assert !FAIL_ON_EQUALS_FOR_TEST
666-
: "Status.equals called; disable this by setting " + TEST_EQUALS_FAILURE_PROPERTY;
667661
return super.equals(obj);
668662
}
669663

examples/android/clientcache/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ android {
3232
}
3333

3434
protobuf {
35-
protoc { artifact = 'com.google.protobuf:protoc:3.24.0' }
35+
protoc { artifact = 'com.google.protobuf:protoc:3.25.1' }
3636
plugins {
3737
grpc { artifact = 'io.grpc:protoc-gen-grpc-java:1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
3838
}
@@ -60,6 +60,6 @@ dependencies {
6060
implementation 'org.apache.tomcat:annotations-api:6.0.53'
6161

6262
testImplementation 'junit:junit:4.13.2'
63-
testImplementation 'com.google.truth:truth:1.0.1'
63+
testImplementation 'com.google.truth:truth:1.1.5'
6464
testImplementation 'io.grpc:grpc-testing:1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
6565
}

examples/android/helloworld/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ android {
3030
}
3131

3232
protobuf {
33-
protoc { artifact = 'com.google.protobuf:protoc:3.24.0' }
33+
protoc { artifact = 'com.google.protobuf:protoc:3.25.1' }
3434
plugins {
3535
grpc { artifact = 'io.grpc:protoc-gen-grpc-java:1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
3636
}

examples/android/routeguide/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ android {
3030
}
3131

3232
protobuf {
33-
protoc { artifact = 'com.google.protobuf:protoc:3.24.0' }
33+
protoc { artifact = 'com.google.protobuf:protoc:3.25.1' }
3434
plugins {
3535
grpc { artifact = 'io.grpc:protoc-gen-grpc-java:1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
3636
}

examples/android/strictmode/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ android {
3131
}
3232

3333
protobuf {
34-
protoc { artifact = 'com.google.protobuf:protoc:3.24.0' }
34+
protoc { artifact = 'com.google.protobuf:protoc:3.25.1' }
3535
plugins {
3636
grpc { artifact = 'io.grpc:protoc-gen-grpc-java:1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
3737
}

examples/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ java {
2424
// Feel free to delete the comment at the next line. It is just for safely
2525
// updating the version in our release process.
2626
def grpcVersion = '1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
27-
def protobufVersion = '3.24.0'
27+
def protobufVersion = '3.25.1'
2828
def protocVersion = protobufVersion
2929

3030
dependencies {
@@ -40,7 +40,7 @@ dependencies {
4040

4141
testImplementation "io.grpc:grpc-testing:${grpcVersion}"
4242
testImplementation "junit:junit:4.13.2"
43-
testImplementation "org.mockito:mockito-core:3.4.0"
43+
testImplementation "org.mockito:mockito-core:4.4.0"
4444
}
4545

4646
protobuf {

examples/example-alts/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ java {
2525
// Feel free to delete the comment at the next line. It is just for safely
2626
// updating the version in our release process.
2727
def grpcVersion = '1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
28-
def protocVersion = '3.24.0'
28+
def protocVersion = '3.25.1'
2929

3030
dependencies {
3131
// grpc-alts transitively depends on grpc-netty-shaded, grpc-protobuf, and grpc-stub

examples/example-debug/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ java {
2626
// Feel free to delete the comment at the next line. It is just for safely
2727
// updating the version in our release process.
2828
def grpcVersion = '1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
29-
def protobufVersion = '3.24.0'
29+
def protobufVersion = '3.25.1'
3030

3131
dependencies {
3232
implementation "io.grpc:grpc-protobuf:${grpcVersion}"

examples/example-debug/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<properties>
1414
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1515
<grpc.version>1.61.0-SNAPSHOT</grpc.version><!-- CURRENT_GRPC_VERSION -->
16-
<protoc.version>3.24.0</protoc.version>
16+
<protoc.version>3.25.1</protoc.version>
1717
<!-- required for jdk9 -->
1818
<maven.compiler.source>1.8</maven.compiler.source>
1919
<maven.compiler.target>1.8</maven.compiler.target>
@@ -58,7 +58,7 @@
5858
<dependency> <!-- prevent downgrade of version in protobuf-java-util from grpc-services -->
5959
<groupId>com.google.guava</groupId>
6060
<artifactId>guava</artifactId>
61-
<version>32.0.1-jre</version>
61+
<version>32.1.3-jre</version>
6262
</dependency>
6363
<dependency>
6464
<groupId>junit</groupId>

examples/example-gauth/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ java {
2525
// Feel free to delete the comment at the next line. It is just for safely
2626
// updating the version in our release process.
2727
def grpcVersion = '1.61.0-SNAPSHOT' // CURRENT_GRPC_VERSION
28-
def protobufVersion = '3.24.0'
28+
def protobufVersion = '3.25.1'
2929
def protocVersion = protobufVersion
3030

3131

@@ -34,7 +34,7 @@ dependencies {
3434
implementation "io.grpc:grpc-stub:${grpcVersion}"
3535
implementation "io.grpc:grpc-auth:${grpcVersion}"
3636
compileOnly "org.apache.tomcat:annotations-api:6.0.53"
37-
implementation "com.google.auth:google-auth-library-oauth2-http:0.9.0"
37+
implementation "com.google.auth:google-auth-library-oauth2-http:1.4.0"
3838
implementation "com.google.api.grpc:grpc-google-cloud-pubsub-v1:0.1.24"
3939
runtimeOnly "io.grpc:grpc-netty-shaded:${grpcVersion}"
4040
}

0 commit comments

Comments
 (0)