stats/opentelemetry: Cleanup OpenTelemetry API's before stabilization#7874
Merged
zasweq merged 4 commits intogrpc:masterfrom Dec 2, 2024
Merged
stats/opentelemetry: Cleanup OpenTelemetry API's before stabilization#7874zasweq merged 4 commits intogrpc:masterfrom
zasweq merged 4 commits intogrpc:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7874 +/- ##
==========================================
+ Coverage 81.94% 82.12% +0.17%
==========================================
Files 377 377
Lines 38120 38112 -8
==========================================
+ Hits 31239 31298 +59
+ Misses 5572 5520 -52
+ Partials 1309 1294 -15
|
dfawley
reviewed
Nov 26, 2024
Member
dfawley
left a comment
There was a problem hiding this comment.
LGTM, just some minor wording suggestions. Please check out the edits-as-commits and suggested changes.
Comment on lines
77
to
82
| // cardinality and could cause severe memory or performance problems. On | ||
| // Client Side, to record the method name along with metric instead of | ||
| // bucketing into "other pass a grpc.StaticMethodCallOption as a call option | ||
| // into Invoke or NewStream. | ||
| // | ||
| // This only applies for server side metrics. |
Member
There was a problem hiding this comment.
Suggested change
| // cardinality and could cause severe memory or performance problems. On | |
| // Client Side, to record the method name along with metric instead of | |
| // bucketing into "other pass a grpc.StaticMethodCallOption as a call option | |
| // into Invoke or NewStream. | |
| // | |
| // This only applies for server side metrics. | |
| // cardinality and could cause severe memory or performance problems. | |
| // | |
| // This only applies for server-side metrics. For clients, to record | |
| // the method name in the attributes, pass grpc.StaticMethodCallOption | |
| // to Invoke or NewStream. Note that when using protobuf generated | |
| // clients, this CallOption is included automatically. |
Comment on lines
+85
to
+86
| // OptionalLabels specifies a list of optional labels that will be included | ||
| // on any metrics that have corresponding optional labels configured. |
Member
There was a problem hiding this comment.
Suggested change
| // OptionalLabels specifies a list of optional labels that will be included | |
| // on any metrics that have corresponding optional labels configured. | |
| // OptionalLabels specifies a list of optional labels to enable on any | |
| // metrics that support them. |
Contributor
Author
There was a problem hiding this comment.
Yeah I couldn't figure out a way to tersely convey it's just the subset that are "supported" that are enabled. (i.e. it's not always the full set added optionally, but the ones that are actually also configured. Changed to your suggestion.
dfawley
approved these changes
Nov 26, 2024
93e5272 to
7f99944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up some OpenTelemetry API's before stabilization.
RELEASE NOTES: