stream: add jitter to retry backoff in accordance with gRFC A6#7869
stream: add jitter to retry backoff in accordance with gRFC A6#7869dfawley merged 2 commits intogrpc:masterfrom
Conversation
Update the delay calculation to reflect the updated gRFC
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7869 +/- ##
==========================================
- Coverage 82.04% 82.00% -0.05%
==========================================
Files 375 375
Lines 37984 37984
==========================================
- Hits 31165 31148 -17
- Misses 5532 5540 +8
- Partials 1287 1296 +9
|
|
@isgj Thanks for raising the PR. Can you add an end to end test to verify the same? |
|
Would be good if we could update the README of examples for retry feature. |
@aranjans can you point to the README and the example file that needs updating? |
The README already points to the right gRFC https://github.com/grpc/grpc-go/blob/master/examples/features/retry/README.md?plain=1#L7
I see the tests at https://github.com/grpc/grpc-go/blob/master/test/retry_test.go. |
|
@isgj Yes that's the correct reference to README.
Overall this change LGTM, adding the @easwars as second reviewer to take a look. |
Update the delay calculation to reflect the updated gRFC
Address #7514
RELEASE NOTES: