credentials/alts: avoid SRV and TXT lookups for handshaker service#7861
Merged
dfawley merged 4 commits intogrpc:masterfrom Nov 22, 2024
Merged
credentials/alts: avoid SRV and TXT lookups for handshaker service#7861dfawley merged 4 commits intogrpc:masterfrom
dfawley merged 4 commits intogrpc:masterfrom
Conversation
…cords for handshaker service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7861 +/- ##
==========================================
+ Coverage 81.84% 81.92% +0.07%
==========================================
Files 374 375 +1
Lines 37993 37982 -11
==========================================
+ Hits 31096 31115 +19
+ Misses 5598 5567 -31
- Partials 1299 1300 +1
|
dfawley
reviewed
Nov 21, 2024
Member
dfawley
left a comment
There was a problem hiding this comment.
Please add comments in both places explaining why we're doing these things. Otherwise LGTM, thanks.
Contributor
Author
|
PTAL |
dfawley
approved these changes
Nov 22, 2024
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Nov 25, 2024
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Nov 26, 2024
purnesh42H
pushed a commit
that referenced
this pull request
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dialing the handshake service, disable the service config to ignore any provided by the resolver.
When doing a DNS resolver lookup, don't do an SRV record lookup for the metadata service.
This is a similar approach implemented in grpc/grpc-java#9897.
RELEASE NOTES: none