deps: Remove Go minor version from go.mods#7831
Merged
arjan-bal merged 1 commit intogrpc:masterfrom Nov 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7831 +/- ##
==========================================
+ Coverage 81.91% 82.01% +0.09%
==========================================
Files 374 374
Lines 37930 37930
==========================================
+ Hits 31071 31107 +36
+ Misses 5566 5539 -27
+ Partials 1293 1284 -9 |
|
Adding this to the conversation over at: golang/go#65847 Tracking issues related to the changes to the go/toolchain directive |
1 task
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Nov 26, 2024
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Nov 26, 2024
arjan-bal
added a commit
that referenced
this pull request
Nov 26, 2024
This was referenced Nov 28, 2024
kaovilai
referenced
this pull request
in sigstore/fulcio
Dec 24, 2024
* update golangci-lint to v1.62.x Signed-off-by: cpanato <ctadeu@gmail.com> * update go to min go1.23.4 Signed-off-by: cpanato <ctadeu@gmail.com> --------- Signed-off-by: cpanato <ctadeu@gmail.com>
This was referenced Dec 24, 2024
Closed
bobrik
added a commit
to bobrik/grpc-gateway
that referenced
this pull request
Dec 25, 2024
This is a continuation of grpc-ecosystem#5022 It is mirroring grpc-go: grpc/grpc-go#7831
johanbrandhorst
pushed a commit
to grpc-ecosystem/grpc-gateway
that referenced
this pull request
Dec 27, 2024
This is a continuation of #5022 It is mirroring grpc-go: grpc/grpc-go#7831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go minor versions were added when bumping the go major version from 1.21 to 1.22 by running
go get go@1.22 && go mod tidy. Specifying the minor version is not necessary unless a dependency specifies a go minor version. This PR removes the minor version from all but one go.mod file which is used for testing.Why
As mentioned in this thread, grpc-go being a library should not specify a patch version.
RELEASE NOTES: