Skip to content

fix: add -c flags when building go test#4473

Merged
caarlos0 merged 2 commits intogoreleaser:mainfrom
fl0Lec:fl/build.test.fix
Dec 12, 2023
Merged

fix: add -c flags when building go test#4473
caarlos0 merged 2 commits intogoreleaser:mainfrom
fl0Lec:fl/build.test.fix

Conversation

@fl0Lec
Copy link
Copy Markdown
Contributor

@fl0Lec fl0Lec commented Dec 12, 2023

when building a go test without the -c flag like so:

 builds:
- command: test
  binary: env.test
  dir: ./internal/builders/golang
  no_main_check: true

will result in the error: exit status 1: fork/exec : exec format error

adding the -c flags when not present in the flags
adding unit test

#4462

when building a go test without the `-c` flag like so:
```
 builds:
- command: test
  binary: env.test
  dir: ./internal/builders/golang
  no_main_check: true
  ```

will result in the error: `exit status 1: fork/exec : exec format error`

adding the -c flags when not present in the flags
adding unit test
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f54b5e) 83.82% compared to head (93e2807) 83.82%.
Report is 1 commits behind head on main.

❗ Current head 93e2807 differs from pull request most recent head 9debe8a. Consider uploading reports for the commit 9debe8a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4473   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         135      135           
  Lines       12819    12821    +2     
=======================================
+ Hits        10745    10747    +2     
  Misses       1650     1650           
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread internal/builders/golang/build_test.go Outdated
@caarlos0 caarlos0 merged commit 159211a into goreleaser:main Dec 12, 2023
@caarlos0
Copy link
Copy Markdown
Member

thanks!

@github-actions github-actions Bot added this to the v2.0.0 milestone Dec 12, 2023
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.23.0 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants