Skip to content

fix(skips): print all steps that will be skipped#4319

Merged
caarlos0 merged 1 commit intomainfrom
skips-imp
Sep 20, 2023
Merged

fix(skips): print all steps that will be skipped#4319
caarlos0 merged 1 commit intomainfrom
skips-imp

Conversation

@caarlos0
Copy link
Copy Markdown
Member

this will log everything that's being skipped in the beginning of the release process.

also added some tests to skips

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2023
@caarlos0 caarlos0 self-assigned this Sep 20, 2023
@caarlos0 caarlos0 added enhancement New feature or request and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@caarlos0 caarlos0 marked this pull request as ready for review September 20, 2023 15:16
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07d2172
Status: ✅  Deploy successful!
Preview URL: https://235c5572.goreleaser.pages.dev
Branch Preview URL: https://skips-imp.goreleaser.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2023

Codecov Report

Merging #4319 (07d2172) into main (d5766b2) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4319      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.01%     
==========================================
  Files         133      133              
  Lines       12683    12695      +12     
==========================================
+ Hits        10637    10649      +12     
  Misses       1629     1629              
  Partials      417      417              
Files Changed Coverage Δ
internal/pipe/winget/winget.go 84.14% <ø> (ø)
cmd/release.go 80.95% <100.00%> (+0.46%) ⬆️
internal/skips/skips.go 73.17% <100.00%> (+6.50%) ⬆️

@caarlos0 caarlos0 merged commit bedf38c into main Sep 20, 2023
@caarlos0 caarlos0 deleted the skips-imp branch September 20, 2023 16:15
@github-actions github-actions Bot added this to the v1.21.0 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant