Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: add retry and timeout for batch dml#1107

Merged
harshachinta merged 7 commits intogoogleapis:mainfrom
harshachinta:retry_timeout_batch_dml
Mar 6, 2024
Merged

feat: add retry and timeout for batch dml#1107
harshachinta merged 7 commits intogoogleapis:mainfrom
harshachinta:retry_timeout_batch_dml

Conversation

@harshachinta
Copy link
Copy Markdown
Contributor

@harshachinta harshachinta commented Feb 26, 2024 •
edited
Loading

Fixes b/326596176

This PR makes the following changes

  1. allows setting retry and timeout to batch_update method. This PR feat: add support for custom timeout and retry parameters in execute_update method in transactions #251 added changes only to few methods.
  2. Add a public sample for retry and timeout. https://cloud.google.com/spanner/docs/custom-timeout-and-retry

Fixes #927

@harshachinta harshachinta requested a review from a team as a code owner February 26, 2024 11:53
@harshachinta harshachinta requested a review from a team February 26, 2024 11:53
@harshachinta harshachinta requested a review from a team as a code owner February 26, 2024 11:53
@harshachinta harshachinta requested a review from ohmayr February 26, 2024 11:53
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Feb 26, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Feb 26, 2024
surbhigarg92
surbhigarg92 reviewed Mar 6, 2024
View reviewed changes
surbhigarg92
surbhigarg92 approved these changes Mar 6, 2024
View reviewed changes
harshachinta
harshachinta commented Mar 6, 2024
View reviewed changes
@harshachinta harshachinta enabled auto-merge (squash) March 6, 2024 11:29
@harshachinta harshachinta merged commit 4f6340b into googleapis:main Mar 6, 2024
@release-please release-please bot mentioned this pull request Mar 6, 2024
Merged
This was referenced Mar 31, 2026
Open
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ohmayr ohmayr Awaiting requested review from ohmayr ohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add sample for passing timeout and retry parameters

2 participants

@harshachinta @surbhigarg92