This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: adds xfail marks to tests that are known to fail#189
Merged
chalmerlowe merged 3 commits intomainfrom Jun 12, 2023
Merged
Conversation
chalmerlowe
commented
Jun 12, 2023
tswast
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three tests that are currently failing. We did an investigation but were unable to nail down the exact cause. More research is gonna be necessary but I need to focus on several other pressing items in the interim. Rather than leave these tests continually failing and leaving these issues looming I am marking them as
xfailsso we can close out the open issues.Fixes #182 🦕
Fixes #183 🦕
Fixes #185 🦕