Skip to content

build!: drop node 10 from engines list, update typescript to 4.6.3#300

Merged
bcoe merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:node-12
Apr 22, 2022
Merged

build!: drop node 10 from engines list, update typescript to 4.6.3#300
bcoe merged 1 commit intogoogleapis:mainfrom
ddelgrosso1:node-12

Conversation

@ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Apr 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner April 22, 2022 15:42
@generated-files-bot
Copy link

generated-files-bot bot commented Apr 22, 2022

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 22, 2022
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 22, 2022
@bcoe bcoe merged commit fed2f14 into googleapis:main Apr 22, 2022
@release-please release-please bot mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelgrosso1 @bcoe